Fix: Restore Mirror Timers (Fatigue, Breath, etc.)#126
Open
Neeo1504 wants to merge 8 commits intoDaleHuntGB:mainfrom
Open
Fix: Restore Mirror Timers (Fatigue, Breath, etc.)#126Neeo1504 wants to merge 8 commits intoDaleHuntGB:mainfrom
Neeo1504 wants to merge 8 commits intoDaleHuntGB:mainfrom
Conversation
Update CastBar.lua
Update Globals.lua
Update Core.lua
Update EventManager.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the addon loaded, the standard mirror timers (fatigue, breath, underwater, etc.) disappeared. The addon was calling
PlayerCastingBarFrame:UnregisterAllEvents()andPlayerCastingBarFrame:Hide(), which broke the event system that mirror timers rely on. Even after attempts to manually show the timer frames, they remained invisible because the underlying events were no longer being processed.Solution
SetAlpha(0)) and disable mouse interaction, but leave it alive so that mirror timers continue to receive necessary events.BCDM:RestoreMirrorFrames()that finds the correct container (MirrorTimerContainerin Midnight) and shows/updates all timer bars.Changes
CastBar.luaBCDM:CreateCastBar()UnregisterAllEvents()andHide()withSetAlpha(0)andEnableMouse(false).Globals.luaBCDM:RestoreMirrorFrames()Core.luaBetterCooldownManager:OnEnable()RestoreMirrorFramesafter initialisation.EventManager.luaBCDM:SetupEventManager()RestoreMirrorFramesafter spec change and world load events.Result
Mirror timers are now restored and work correctly. The custom cast bar remains functional, and the standard Blizzard cast bar is hidden visually without interfering with the event system.